fix(ci): restore dist/.gitkeep after UI rebuild (unblock v0.4.0-beta.1 signing)#125
Merged
Conversation
…e.yml GoReleaser aborts with 'git is in a dirty state' when the release tag commits internal/ui/dist/.gitkeep (as scripts/release.sh does via `touch`): release.yml rebuilds the UI, vite's emptyOutDir deletes the committed .gitkeep, and the resulting 'D internal/ui/dist/.gitkeep' fails GoReleaser's clean-tree check. Restore the placeholder after the rebuild so the tree matches the tag. No-op for tags that don't track .gitkeep (e.g. v0.3.1). Unblocks the v0.4.0-beta.1 signed-artifact build via workflow_dispatch recovery. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LDQVJrixs2nJoea67a8pEG
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoReleaser's dirty-tree check aborts the release when the tag commits
internal/ui/dist/.gitkeep(whichscripts/release.shdoes): release.yml rebuilds the UI, viteemptyOutDirdeletes the committed.gitkeep, andD internal/ui/dist/.gitkeeptrips the check. v0.4.0-beta.1 hit exactly this (run 27799006159). Restore the placeholder after the rebuild so the tree matches the tag; no-op for tags without.gitkeep(v0.3.1). After merge, recover beta.1 viaworkflow_dispatch -f tag=v0.4.0-beta.1(mode: append).🤖 Generated with Claude Code
https://claude.ai/code/session_01LDQVJrixs2nJoea67a8pEG